linux-kernel - Re: tc qdisc command partially broken with patch-4.14.76-77 up to patch-4.14.77-78

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 25 Oct 2018 14:49:11 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     astx@...-it.at
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: tc qdisc command partially broken with patch-4.14.76-77 up to patch-4.14.77-78

On Thu, Oct 25, 2018 at 1:14 PM astx <astx@...-it.at> wrote:
>
> tc qdisc command is partially broken after applying patch-4.14.76-77.
> Applying patch-4.14.77-78 didn't fix it.
>
> Test command:
>    tc qdisc add dev eth0 root handle 1: hfsc default fffd
> Kernel answer:
>    RTNETLINK answers: Numerical result out of range
>
> I have identified the problematic sub-patch out of patch-4.14.76-77 to
> be the problem:
>
>     diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
>     index 22bc6fc48311..cd69aa067543 100644
>
> Without this small patch the above "tc qdisc" command works like a charm.

Should be fixed by the following commit:

commit e72bde6b66299602087c8c2350d36a525e75d06e
Author: David Ahern <dsahern@...il.com>
Date:   Wed Oct 24 08:32:49 2018 -0700

    net: sched: Remove TCA_OPTIONS from policy


Thanks.