linux-kernel - Re: [PATCH] staging: axis-fifo: Fix line over 80 characters error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181025060533.mfmdozimla7wq2sg@mwanda>
Date:   Thu, 25 Oct 2018 09:05:33 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Aleksa Zdravkovic <alex.zdravkovic98@...il.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: axis-fifo: Fix line over 80 characters error

On Wed, Oct 24, 2018 at 05:05:53PM +0200, Aleksa Zdravkovic wrote:
> This patch fixes the checkpatch.pl warning:
> 
> WARNING: line over 80 characters
> +			 (write_timeout >= 0) ? msecs_to_jiffies(write_timeout) :
> 
> Signed-off-by: Aleksa Zdravkovic <alex.zdravkovic98@...il.com>
> ---
>  drivers/staging/axis-fifo/axis-fifo.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index c18bf31f55b6..2f609712f507 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -482,10 +482,10 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
>  		spin_lock_irq(&fifo->write_queue_lock);
>  		ret = wait_event_interruptible_lock_irq_timeout
>  			(fifo->write_queue,
> -			 ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
> +			ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
>  				>= words_to_write,
> -			 fifo->write_queue_lock,
> -			 (write_timeout >= 0) ? msecs_to_jiffies(write_timeout) :
> +			fifo->write_queue_lock,
> +			(write_timeout >= 0) ? msecs_to_jiffies(write_timeout) :
>  				MAX_SCHEDULE_TIMEOUT);

The original was fine.  Just leave it.

Checkpatch.pl is only useful if it improves the readability for humans.

regards,
dan carpenter