linux-kernel - RE: [PATCH 1/4] doc/layerscape-pci: update the PCIe compatible strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB5PR04MB12216556360604A225BAFC1F84F70@DB5PR04MB1221.eurprd04.prod.outlook.com>
Date:   Thu, 25 Oct 2018 09:27:42 +0000
From:   "Z.q. Hou" <zhiqiang.hou@....com>
To:     Rob Herring <robh@...nel.org>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Leo Li <leoyang.li@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        Mingkai Hu <mingkai.hu@....com>,
        "M.h. Lian" <minghuan.lian@....com>
Subject: RE: [PATCH 1/4] doc/layerscape-pci: update the PCIe compatible
 strings

Hi Rob,

Thanks a lot for your comments!
 
> -----Original Message-----
> From: Rob Herring <robh@...nel.org>
> Sent: 2018年10月17日 21:52
> To: Z.q. Hou <zhiqiang.hou@....com>
> Cc: linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> linux-pci@...r.kernel.org; devicetree@...r.kernel.org; Leo Li
> <leoyang.li@....com>; shawnguo@...nel.org; mark.rutland@....com;
> bhelgaas@...gle.com; Mingkai Hu <mingkai.hu@....com>; M.h. Lian
> <minghuan.lian@....com>
> Subject: Re: [PATCH 1/4] doc/layerscape-pci: update the PCIe compatible
> strings
> 
> On Mon, Oct 08, 2018 at 11:14:25AM +0800, Zhiqiang Hou wrote:
> > From: Hou Zhiqiang <Zhiqiang.Hou@....com>
> >
> > The pcie compatible string for LS1043A was lost, so add it.
> 
> PCIe
> 
> The subject could be improved to say exactly what compatible string you are
> adding. And the subject should start with "dt-bindings: pci: ..."
>

Yes, will correct them in v2.
 
> >
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@....com>
> > ---
> >  Documentation/devicetree/bindings/pci/layerscape-pci.txt | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > index 66df1e81e0b8..5eb1c202932f 100644
> > --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > @@ -18,6 +18,7 @@ Required properties:
> >          "fsl,ls2088a-pcie"
> >          "fsl,ls1088a-pcie"
> >          "fsl,ls1046a-pcie"
> > +        "fsl,ls1043a-pcie"
> >          "fsl,ls1012a-pcie"
> >  - reg: base addresses and lengths of the PCIe controller register blocks.
> >  - interrupts: A list of interrupt outputs of the controller. Must
> > contain an
> > --
> > 2.17.1
> >