linux-kernel - RE: [PATCH V1 2/2] Documentation: can: flexcan: Add stop-mode property to device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB7PR04MB4618F0289926D923EB908A14E6F70@DB7PR04MB4618.eurprd04.prod.outlook.com>
Date:   Thu, 25 Oct 2018 00:40:47 +0000
From:   Joakim Zhang <qiangqing.zhang@....com>
To:     Rob Herring <robh@...nel.org>
CC:     "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
        "wg@...ndegger.com" <wg@...ndegger.com>,
        "mkl@...gutronix.de" <mkl@...gutronix.de>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        "A.s. Dong" <aisheng.dong@....com>
Subject: RE: [PATCH V1 2/2] Documentation: can: flexcan: Add stop-mode
 property to device tree


-----Original Message-----
From: Rob Herring [mailto:robh@...nel.org] 
Sent: 2018年10月25日 7:57
To: Joakim Zhang <qiangqing.zhang@....com>
Cc: linux-can@...r.kernel.org; wg@...ndegger.com; mkl@...gutronix.de; mark.rutland@....com; devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; dl-linux-imx <linux-imx@....com>; A.s. Dong <aisheng.dong@....com>
Subject: Re: [PATCH V1 2/2] Documentation: can: flexcan: Add stop-mode property to device tree

On Tue, Oct 23, 2018 at 05:17:10AM +0000, Joakim Zhang wrote:
> From: Dong Aisheng <aisheng.dong@....com>
> 
> The FlexCAN controller can parse the stop-mode property to enable CAN 
> self wakeup feature.
> 
> Signed-off-by: Dong Aisheng <aisheng.dong@....com>
> Signed-off-by: Joakim Zhang <qiangqing.zhang@....com>
> ---
>  Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 8 
> ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt 
> b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> index bfc0c433654f..b5ccfc9c14fb 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> @@ -24,6 +24,14 @@ Optional properties:
>                if this property is present then controller is assumed to be big
>                endian.
>  
> +- stop-mode: register bits of stop mode control, the format is

Should have a vendor prefix: fsl,stop-mode

Okay, I will add it. Thanks a lot!

Best Regards,
Joakim Zhang

> +			<&gpr req_gpr req_bit ack_gpr ack_bit>.
> +			gpr is the phandle to general purpose register node.
> +			req_gpr is the gpr register offset of CAN stop request.
> +			req_bit is the bit offset of CAN stop request.
> +			ack_gpr is the gpr register offset of CAN stop acknowledge.
> +			ack_bit is the bit offset of CAN stop acknowledge.
> +
>  Example:
>  
>  	can@...00 {
> --
> 2.17.1
>