linux-kernel - Re: [PATCH] leds: gpio: set led_dat->gpiod pointer for OF defined GPIO leds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaHBf1eJig5t2_u89HhKb2Ne8FV1AhfdZ3Yy_XTZQdEqw@mail.gmail.com>
Date:   Thu, 25 Oct 2018 14:55:20 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     liviu@...au.co.uk
Cc:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Pavel Machek <pavel@....cz>, linux-leds@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] leds: gpio: set led_dat->gpiod pointer for OF defined
 GPIO leds

On Thu, Oct 18, 2018 at 2:14 AM Liviu Dudau <liviu@...au.co.uk> wrote:

> Commit 45d4c6de4e49 ("leds: gpio: Try to lookup gpiod from device")
> removed the common code path that set the led_dat->gpiod pointer in
> create_gpio_led(), but only added it back for the devices that have
> a valid gpio_led_platform_data structure. Calling gpio_leds_create()
> in gpio_led_probe() is not enough to get a valid gpiod pointer.
>
> Fortunately enough, gpio_leds_create() already gets the needed pointer,
> we just need to assign it to the relevant gpio_led_data structure.
>
> Fixes: 45d4c6de4e49 ("leds: gpio: Try to lookup gpiod from device")
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Jacek Anaszewski <jacek.anaszewski@...il.com>
> Signed-off-by: Liviu Dudau <liviu@...au.co.uk>

Ooops
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij