linux-kernel - RE: [PATCH] drm: fix call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY1PR12MB05028BA16A21896179679800B4F70@BY1PR12MB0502.namprd12.prod.outlook.com>
Date:   Thu, 25 Oct 2018 01:28:55 +0000
From:   "Zhou, David(ChunMing)" <David1.Zhou@....com>
To:     Julia Lawall <julia.lawall@...6.fr>
CC:     "kbuild-all@...org" <kbuild-all@...org>,
        "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        Christian König 
        <easy2remember.chk@...glemail.com>,
        Gustavo Padovan <gustavo@...ovan.org>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Sean Paul <sean@...rly.run>, David Airlie <airlied@...ux.ie>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] drm: fix call_kern.cocci warnings (fwd)

Reviewed-by: Chunming Zhou <david1.zhou@....com>

> -----Original Message-----
> From: Julia Lawall <julia.lawall@...6.fr>
> Sent: Thursday, October 25, 2018 2:57 AM
> To: Zhou, David(ChunMing) <David1.Zhou@....com>
> Cc: kbuild-all@...org; intel-gfx@...ts.freedesktop.org; dri-
> devel@...ts.freedesktop.org; Christian König
> <easy2remember.chk@...glemail.com>; Gustavo Padovan
> <gustavo@...ovan.org>; Maarten Lankhorst
> <maarten.lankhorst@...ux.intel.com>; Sean Paul <sean@...rly.run>; David
> Airlie <airlied@...ux.ie>; dri-devel@...ts.freedesktop.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH] drm: fix call_kern.cocci warnings (fwd)
> 
> The containing function is called with a spin_lock held, so GFP_KERNEL can't
> be used.
> 
> julia
> 
> ---------- Forwarded message ----------
> Date: Tue, 23 Oct 2018 17:14:25 +0800
> From: kbuild test robot <lkp@...el.com>
> To: kbuild@...org
> Cc: Julia Lawall <julia.lawall@...6.fr>
> Subject: [PATCH] drm: fix call_kern.cocci warnings
> 
> CC: kbuild-all@...org
> CC: intel-gfx@...ts.freedesktop.org
> CC: dri-devel@...ts.freedesktop.org
> TO: Chunming Zhou <david1.zhou@....com>
> CC: "Christian König" <easy2remember.chk@...glemail.com>
> CC: Gustavo Padovan <gustavo@...ovan.org>
> CC: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
> CC: Sean Paul <sean@...rly.run>
> CC: David Airlie <airlied@...ux.ie>
> CC: dri-devel@...ts.freedesktop.org
> CC: linux-kernel@...r.kernel.org
> 
> From: kbuild test robot <fengguang.wu@...el.com>
> 
> drivers/gpu/drm/drm_syncobj.c:202:4-14: ERROR: function
> drm_syncobj_find_signal_pt_for_point called on line 390 inside lock on line
> 389 but uses GFP_KERNEL
> 
>  Find functions that refer to GFP_KERNEL but are called with locks held.
> 
> Semantic patch information:
>  The proposed change of converting the GFP_KERNEL is not necessarily the
> correct one.  It may be desired to unlock the lock, or to not call the  function
> under the lock in the first place.
> 
> Generated by: scripts/coccinelle/locks/call_kern.cocci
> 
> Fixes: 48197bc564c7 ("drm: add syncobj timeline support v9")
> CC: Chunming Zhou <david1.zhou@....com>
> Signed-off-by: kbuild test robot <fengguang.wu@...el.com>
> ---
> 
> tree:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
> head:   8d7ffd2298c607c3e1a16f94d51450d7940fd6a7
> commit: 48197bc564c7a1888c86024a1ba4f956e0ec2300 [1968/2033] drm: add
> syncobj timeline support v9
> :::::: branch date: 4 hours ago
> :::::: commit date: 5 days ago
> 
> Please take the patch only if it's a positive warning. Thanks!
> 
>  drm_syncobj.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/gpu/drm/drm_syncobj.c
> +++ b/drivers/gpu/drm/drm_syncobj.c
> @@ -199,7 +199,7 @@ static struct dma_fence
>  	    (point <= syncobj->timeline)) {
>  		struct drm_syncobj_stub_fence *fence =
>  			kzalloc(sizeof(struct drm_syncobj_stub_fence),
> -				GFP_KERNEL);
> +				GFP_ATOMIC);
> 
>  		if (!fence)
>  			return NULL;