linux-kernel - Re: [PATCH AUTOSEL 4.4 15/65] btrfs: don't create or leak aliased root while cleaning up orphans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181025151247.GE16290@suse.cz>
Date:   Thu, 25 Oct 2018 17:12:48 +0200
From:   David Sterba <dsterba@...e.cz>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Chris Mason <clm@...com>, Jeff Mahoney <jeffm@...e.com>
Subject: Re: [PATCH AUTOSEL 4.4 15/65] btrfs: don't create or leak aliased
 root while cleaning up orphans

On Thu, Oct 25, 2018 at 10:16:15AM -0400, Sasha Levin wrote:
> From: Jeff Mahoney <jeffm@...e.com>
> 
> [ Upstream commit 35bbb97fc898aeb874cb7c8b746f091caa359994 ]
> 
> commit 909c3a22da3 (Btrfs: fix loading of orphan roots leading to BUG_ON)
> avoids the BUG_ON but can add an aliased root to the dead_roots list or
> leak the root.
> 
> Since we've already been loading roots into the radix tree, we should
> use it before looking the root up on disk.
> 
> Cc: <stable@...r.kernel.org> # 4.5

Ack for 4.4 stable.