linux-kernel - Re: [alsa-devel] [PATCH v2] staging: bcm2835-audio: interpolate audio delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5bc8295a-1e38-99b5-d54c-72e920600f83@gmail.com>
Date:   Thu, 25 Oct 2018 19:20:40 +0200
From:   Kirill Marinushkin <k.marinushkin@...il.com>
To:     Takashi Iwai <tiwai@...e.de>, Mike Brady <mikebrady@...com.net>
Cc:     stefan.wahren@...e.com, devel@...verdev.osuosl.org,
        alsa-devel@...a-project.org, f.fainelli@...il.com, eric@...olt.net,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        julia.lawall@...6.fr, linux-rpi-kernel@...ts.infradead.org,
        nishka.dasgupta_ug18@...oka.edu.in,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [alsa-devel] [PATCH v2] staging: bcm2835-audio: interpolate audio
 delay

Hello Takashi, Mike,

@Takashi

On 10/25/18 09:37, Takashi Iwai wrote:
> Well, in the API POV, it's nothing wrong to keep hwptr sticking while
> updating only delay value.  It implies that the hardware chip doesn't
> provide the hwptr update.

Thank you for the clarification. Modifying `runtime->delay` from the `pointer`
function looked wrong for me. Now I understand the motivation and the use-case.
I will be more careful when analyzing the code which doesn't fit my expectations.

@Mike

I was wrong. You can ignore my comments. Please don't take them personal: it's
all about having high-quality code in kernel.

Best Regards,
Kirill