linux-kernel - Re: [PATCH] proc: use ns_capable instead of capable for timerslack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLVUYEKXs2ATieTd-3Zs4AbhSPpeGQS=PMiSGbXGkx_JAA@mail.gmail.com>
Date:   Thu, 25 Oct 2018 10:20:18 -0700
From:   John Stultz <john.stultz@...aro.org>
To:     bmgordon@...gle.com
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Kees Cook <keescook@...omium.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Arjan van de Ven <arjan@...ux.intel.com>,
        Oren Laadan <orenl@...lrox.com>,
        Ruchi Kandoi <kandoiruchi@...gle.com>,
        Rom Lemarchand <romlem@...roid.com>,
        Todd Kjos <tkjos@...gle.com>, Colin Cross <ccross@...roid.com>,
        Nick Kralevich <nnk@...gle.com>,
        Dmitry Shmidt <dimitrysh@...gle.com>,
        Elliott Hughes <enh@...gle.com>,
        Android Kernel Team <kernel-team@...roid.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] proc: use ns_capable instead of capable for timerslack_ns

On Wed, Oct 17, 2018 at 3:47 PM,  <bmgordon@...gle.com> wrote:
> From: Benjamin Gordon <bmgordon@...gle.com>
>
> Access to timerslack_ns is controlled by a process having CAP_SYS_NICE
> in its effective capability set, but the current check looks in the root
> namespace instead of the process' user namespace.  Since a process is
> allowed to do other activities controlled by CAP_SYS_NICE inside a
> namespace, it should also be able to adjust timerslack_ns.
>
> Signed-off-by: Benjamin Gordon <bmgordon@...gle.com>
> Cc: John Stultz <john.stultz@...aro.org>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: "Serge E. Hallyn" <serge@...lyn.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Arjan van de Ven <arjan@...ux.intel.com>
> Cc: Oren Laadan <orenl@...lrox.com>
> Cc: Ruchi Kandoi <kandoiruchi@...gle.com>
> Cc: Rom Lemarchand <romlem@...roid.com>
> Cc: Todd Kjos <tkjos@...gle.com>
> Cc: Colin Cross <ccross@...roid.com>
> Cc: Nick Kralevich <nnk@...gle.com>
> Cc: Dmitry Shmidt <dimitrysh@...gle.com>
> Cc: Elliott Hughes <enh@...gle.com>
> Cc: Android Kernel Team <kernel-team@...roid.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> ---
>  fs/proc/base.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/proc/base.c b/fs/proc/base.c
> index 7e9f07bf260d..4b50937dff80 100644
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -2356,7 +2356,7 @@ static ssize_t timerslack_ns_write(struct file *file, const char __user *buf,
>                 return -ESRCH;
>
>         if (p != current) {
> -               if (!capable(CAP_SYS_NICE)) {
> +               if (!ns_capable(file->f_cred->user_ns, CAP_SYS_NICE)) {
>                         count = -EPERM;
>                         goto out;
>                 }
> @@ -2393,7 +2393,7 @@ static int timerslack_ns_show(struct seq_file *m, void *v)
>
>         if (p != current) {
>
> -               if (!capable(CAP_SYS_NICE)) {
> +               if (!ns_capable(seq_user_ns(m), CAP_SYS_NICE)) {
>                         err = -EPERM;
>                         goto out;
>                 }

Looks reasonable to me.
Acked-by: John Stultz <john.stultz@...aro.org>

thanks
-john