linux-kernel - Re: [PATCH v2] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6749376c-930a-3392-6a02-386431a9a432@redhat.com>
Date:   Fri, 26 Oct 2018 13:59:56 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Diego Viola <diego.viola@...il.com>
Cc:     axboe@...nel.dk, tj@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] libata: Apply NOLPM quirk for SAMSUNG
 MZ7TD256HAFV-000L9

Hi,

On 26-10-18 03:58, Diego Viola wrote:
> med_power_with_dipm causes my T450 to freeze with a SAMSUNG
> MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).
> 
> Switching the LPM to max_performance fixes this issue.
> 
> Signed-off-by: Diego Viola <diego.viola@...il.com>

Thank you for the patch, have you updated the firmware and
confirmed that this happens with the latest firmware version too ?

If not please send a new version limiting the blacklist to your
firmware version.

Regards,

Hans




> ---
>   drivers/ata/libata-core.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index a9dd4ea7467d..a7f5202a4815 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4553,6 +4553,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>   	/* These specific Samsung models/firmware-revs do not handle LPM well */
>   	{ "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
>   	{ "SAMSUNG SSD PM830 mSATA *",  "CXM13D1Q", ATA_HORKAGE_NOLPM, },
> +	{ "SAMSUNG MZ7TD256HAFV-000L9", NULL,       ATA_HORKAGE_NOLPM, },
>   
>   	/* devices that don't properly handle queued TRIM commands */
>   	{ "Micron_M500IT_*",		"MU01",	ATA_HORKAGE_NO_NCQ_TRIM |
>