linux-kernel - RE: [PATCH] regulator: bd71837: add <linux/of.h> to fix build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <042F8805D2046347BB8420BEAE397A4066F1CF4C@WILL-MAIL001.REu.RohmEu.com>
Date:   Fri, 26 Oct 2018 06:02:26 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>
Subject: RE: [PATCH] regulator: bd71837: add <linux/of.h> to fix build errors

Hello,

From: Randy Dunlap <rdunlap@...radead.org>

> Fix build error due to missing header file:
>
> drivers/regulator/bd71837-regulator.c:242:3: error: implicit declaration of function 'of_match_ptr' [-Werror=implicit-function-declaration]
>
> Fixes: ba08799e90b5 ("regulator: bd71837: BD71837 PMIC regulator driver")

//snip

> --- lnx-419.orig/drivers/regulator/bd71837-regulator.c
> +++ lnx-419/drivers/regulator/bd71837-regulator.c
> @@ -9,6 +9,7 @@
>  #include <linux/kernel.h>
>  #include <linux/mfd/rohm-bd718x7.h>
>  #include <linux/module.h>
> +#include <linux/of.h>
>  #include <linux/platform_device.h>
>  #include <linux/regulator/driver.h>
>  #include <linux/regulator/machine.h>

Not sure if this is relevant but if I am not mistaken this should already be fixed by: 
df43519eb706edfe951284a825642ce2e1d38d09 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=df43519eb706edfe951284a825642ce2e1d38d09


Br,
    Matti Vaittinen