linux-kernel - Re: [PATCH 2/2] RISC-V: Add support for SECCOMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 27 Oct 2018 00:55:59 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Palmer Dabbelt <palmer@...ive.com>
Cc:     linux-riscv@...ts.infradead.org, aou@...s.berkeley.edu,
        paul@...l-moore.com, eparis@...hat.com, keescook@...omium.org,
        luto@...capital.net, wad@...omium.org,
        Wesley Terpstra <wesley@...ive.com>, dhowells@...hat.com,
        tglx@...utronix.de, pombredanne@...b.com,
        Greg KH <gregkh@...uxfoundation.org>,
        kstewart@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-audit@...hat.com, david.abdurachmanov@...il.com
Subject: Re: [PATCH 2/2] RISC-V: Add support for SECCOMP

I don't know much about seccomp, so just a few general nitpicks:

On Wed, Oct 24, 2018 at 01:40:36PM -0700, Palmer Dabbelt wrote:
> +	bool "Enable seccomp to safely compute untrusted bytecode"
> +
> +	help

The empty line above is odd, please drop it.

> +++ b/arch/riscv/include/asm/seccomp.h
> @@ -0,0 +1,10 @@
> +/* Copyright 2018 SiFive, Inc. */
> +/* SPDX-License-Identifier: GPL-2.0 */

The SPDX tag should go into the first line.

> +#ifndef _ASM_RISCV_SECCOMP_H
> +#define _ASM_RISCV_SECCOMP_H
> +
> +#include <asm/unistd.h>
> +
> +#include <asm-generic/seccomp.h>

And while at it I'd drop this empty line as well.