linux-kernel - Re: [PATCH v3 2/5] kbuild: Removes unnecessary shadowed local variable.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Oct 2018 01:36:20 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Leonardo Brás <leobras.c@...il.com>
Cc:     lkcamp@...ts.libreplanetbr.org, Borislav Petkov <bp@...en8.de>,
        David.Laight@...lab.com, Andy Lutomirski <luto@...nel.org>,
        Ingo Molnar <mingo@...nel.org>, helen@...keco.de,
        Michal Marek <michal.lkml@...kovi.net>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/5] kbuild: Removes unnecessary shadowed local variable.

On Wed, Oct 24, 2018 at 1:04 PM Leonardo Bras <leobras.c@...il.com> wrote:
>
> Removes an unnecessary shadowed local variable (start).
> It was used only once, with the same value it was started before
> the if block.
>
> Signed-off-by: Leonardo Bras <leobras.c@...il.com>



Applied to linux-kbuild
with some fixups in the subject.

Please do not add a period to the end of the subject.






> ---
>  scripts/asn1_compiler.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/asn1_compiler.c b/scripts/asn1_compiler.c
> index c146020fc783..1b28787028d3 100644
> --- a/scripts/asn1_compiler.c
> +++ b/scripts/asn1_compiler.c
> @@ -413,7 +413,7 @@ static void tokenise(char *buffer, char *end)
>
>                         /* Handle string tokens */
>                         if (isalpha(*p)) {
> -                               const char **dir, *start = p;
> +                               const char **dir;
>
>                                 /* Can be a directive, type name or element
>                                  * name.  Find the end of the name.
> --
> 2.19.1
>


-- 
Best Regards
Masahiro Yamada