linux-kernel - Re: [PATCH v2 0/6] staging:iio:ad2s90: Add scale info and improve error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181028165202.52ee89b3@archlinux>
Date:   Sun, 28 Oct 2018 16:52:02 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Matheus Tavares <matheus.bernardino@....br>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Hartmut Knaack <knaack.h@....de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, kernel-usp@...glegroups.com
Subject: Re: [PATCH v2 0/6] staging:iio:ad2s90: Add scale info and improve
 error handling

On Fri, 26 Oct 2018 22:59:59 -0300
Matheus Tavares <matheus.bernardino@....br> wrote:

> This patch set adds scale info to ad2s90's single channel, improve
> error handling in it's functions and fix a possible race condition
> issue.
> 
> The goal with this patch set is to address the points discussed in the
> mailing list in an effort to move ad2s90.c out of staging.
Thanks,

A good series in general.  A few suggested improvements.
If I haven't commented on a patch, usually it means I'm happy with it
and will pick it up with the rest of the series.

Jonathan

> 
> Changes in v2:
>  - Added my S-o-B in patch 5.
> 
> Matheus Tavares (5):
>   staging:iio:ad2s90: Make read_raw return spi_read's error code
>   staging:iio:ad2s90: Make probe handle spi_setup failure
>   staging:iio:ad2s90: Remove always overwritten assignment
>   staging:iio:ad2s90: Move device registration to the end of probe
>   staging:iio:ad2s90: Check channel type at read_raw
> 
> Victor Colombo (1):
>   staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and
>     read_raw
> 
>  drivers/staging/iio/resolver/ad2s90.c | 55 ++++++++++++++++++---------
>  1 file changed, 37 insertions(+), 18 deletions(-)
>