linux-kernel - Re: [PATCH 1/2] i2c: Remove unnecessary call to irq_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181028223041.GI1882@kunai>
Date:   Sun, 28 Oct 2018 22:30:41 +0000
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        patches@...nsource.cirrus.com
Subject: Re: [PATCH 1/2] i2c: Remove unnecessary call to irq_find_mapping

On Fri, Oct 19, 2018 at 09:59:57AM +0100, Charles Keepax wrote:
> irq_create_mapping calls irq_find_mapping internally and will use the
> found mapping if one exists, so there is no need to manually call this
> from i2c_smbus_host_notify_to_irq.
> 
> Signed-off-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Adding Benjamin to recipients. He wrote that code.

> ---
>  drivers/i2c/i2c-core-base.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
> index dc78aa7369def..656f0a6fe3adf 100644
> --- a/drivers/i2c/i2c-core-base.c
> +++ b/drivers/i2c/i2c-core-base.c
> @@ -306,10 +306,7 @@ static int i2c_smbus_host_notify_to_irq(const struct i2c_client *client)
>  	if (client->flags & I2C_CLIENT_TEN)
>  		return -EINVAL;
>  
> -	irq = irq_find_mapping(adap->host_notify_domain, client->addr);
> -	if (!irq)
> -		irq = irq_create_mapping(adap->host_notify_domain,
> -					 client->addr);
> +	irq = irq_create_mapping(adap->host_notify_domain, client->addr);
>  
>  	return irq > 0 ? irq : -ENXIO;
>  }
> -- 
> 2.11.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)