linux-kernel - Re: [RESEND PATCH 1/2] staging: vboxvideo: Change uint32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a74af0ae-70a3-1e10-fff2-32c6ac3b74c7@redhat.com>
Date:   Sun, 28 Oct 2018 12:02:49 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Shayenne da Luz Moura <shayenneluzmoura@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Thayer <michael.thayer@...cle.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        outreachy-kernel@...glegroups.com
Subject: Re: [RESEND PATCH 1/2] staging: vboxvideo: Change uint32_t to u32

Hi,

On 26-10-18 21:04, Shayenne da Luz Moura wrote:
> This change was suggested by checkpath.pl.
> 
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> 
> Signed-off-by: Shayenne da Luz Moura <shayenneluzmoura@...il.com>

So as already mentioned in response to the coverletter of
the first posting of this series.

The drm headers use uint32_t in the prototype definition of the callback
functions we are defining, so the vboxvideo code should use the same even
if the compiler does not warn about the callback implementation having
different parameter types in this case.

To be precise, the page_flip member of struct drm_crtc_funcs is defined as:

         int (*page_flip)(struct drm_crtc *crtc,
                          struct drm_framebuffer *fb,
                          struct drm_pending_vblank_event *event,
                          uint32_t flags,
                          struct drm_modeset_acquire_ctx *ctx);

So our implementation before your patch exactly matches the prototype
which IMHO is the right thing to do.

Regards,

Hans




> ---
>   drivers/staging/vboxvideo/vbox_mode.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c
> index 79836c8fb909..8a1b117990b8 100644
> --- a/drivers/staging/vboxvideo/vbox_mode.c
> +++ b/drivers/staging/vboxvideo/vbox_mode.c
> @@ -311,7 +311,7 @@ static int vbox_crtc_mode_set(struct drm_crtc *crtc,
>   static int vbox_crtc_page_flip(struct drm_crtc *crtc,
>   			       struct drm_framebuffer *fb,
>   			       struct drm_pending_vblank_event *event,
> -			       uint32_t page_flip_flags,
> +			       u32 page_flip_flags,
>   			       struct drm_modeset_acquire_ctx *ctx)
>   {
>   	struct vbox_private *vbox = crtc->dev->dev_private;
>