linux-kernel - Re: [PATCH 8/9] w1: fix whitespaces of struct declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <795912c5ade5a813cf5c70d7085c14c24b553f1d.camel@perches.com>
Date:   Sun, 28 Oct 2018 18:52:23 -0700
From:   Joe Perches <joe@...ches.com>
To:     Steffen Vogel <post@...ffenvogel.de>, linux-kernel@...r.kernel.org
Cc:     Evgeniy Polyakov <zbr@...emap.net>
Subject: Re: [PATCH 8/9] w1: fix whitespaces of struct declarations

On Sun, 2018-10-28 at 23:09 +0100, Steffen Vogel wrote:
> This fixes a warning raised by the checkpatch tool.

checkpatch does not raise any whitespace errors on
this file.

It does suggest that braces could be moved.

$ ./scripts/checkpatch.pl -f --strict drivers/w1/w1_netlink.h
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#1: FILE: drivers/w1/w1_netlink.h:1:
+/*

ERROR: open brace '{' following struct go on the same line
#74: FILE: drivers/w1/w1_netlink.h:74:
+struct w1_netlink_msg
+{

ERROR: open brace '{' following struct go on the same line
#130: FILE: drivers/w1/w1_netlink.h:130:
+struct w1_netlink_cmd
+{

total: 2 errors, 1 warnings, 0 checks, 144 lines checked

> Signed-off-by: Steffen Vogel <post@...ffenvogel.de>
> ---
>  drivers/w1/w1_netlink.h | 28 +++++++++++++---------------
>  1 file changed, 13 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/w1/w1_netlink.h b/drivers/w1/w1_netlink.h
> index 08cbf08f3649..7873eb54352e 100644
> --- a/drivers/w1/w1_netlink.h
> +++ b/drivers/w1/w1_netlink.h
> @@ -61,19 +61,18 @@ enum w1_netlink_message_types {
>   * The netlink connector data sequence is, struct nlmsghdr, struct cn_msg,
>   * then one or more struct w1_netlink_msg (each with optional data).
>   */
> -struct w1_netlink_msg does n
> -{
> -	__u8				type;
> -	__u8				status;
> -	__u16				len;
> +struct w1_netlink_msg {
> +	__u8 type;
> +	__u8 status;
> +	__u16 len;
>  	union {
> -		__u8			id[8];
> +		__u8 id[8];
>  		struct w1_mst {
> -			__u32		id;
> -			__u32		res;
> +			__u32 id;
> +			__u32 res;
>  		} mst;
>  	} id;
> -	__u8				data[0];
> +	__u8 data[0];
>  };
>  
>  /**
> @@ -117,12 +116,11 @@ enum w1_commands {
>   * One or more struct w1_netlink_cmd is placed starting at w1_netlink_msg.data
>   * each with optional data.
>   */
> -struct w1_netlink_cmd
> -{
> -	__u8				cmd;
> -	__u8				res;
> -	__u16				len;
> -	__u8				data[0];
> +struct w1_netlink_cmd {
> +	__u8 cmd;
> +	__u8 res;
> +	__u16 len;
> +	__u8 data[0];
>  };
>  
>  #ifdef __KERNEL__