linux-kernel - Re: [PATCH v2 7/7] arm64: dts: qcom: apq8016-sbc: Standardize LED labels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHLCerM91ukzAJZHaxXxwoHU-6mVUV+X9_y_Rs0zmybNnRJCfA@mail.gmail.com>
Date:   Mon, 29 Oct 2018 14:47:11 +0530
From:   Amit Kucheria <amit.kucheria@...aro.org>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     Rob Herring <robh@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
        ezequiel@...labora.com, Wei Xu <xuwei5@...ilicon.com>,
        Michal Simek <michal.simek@...inx.com>, pavel@....cz,
        Andy Gross <andy.gross@...aro.org>, linux-leds@...r.kernel.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        lakml <linux-arm-kernel@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-rockchip@...ts.infradead.org,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-soc@...r.kernel.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>, koen.kooi@...aro.org,
        nicolas.dechesne@...aro.org
Subject: Re: [PATCH v2 7/7] arm64: dts: qcom: apq8016-sbc: Standardize LED labels

On Mon, Oct 29, 2018 at 2:31 PM Manivannan Sadhasivam
<manivannan.sadhasivam@...aro.org> wrote:
>
> For all 96Boards, the following standard is used for onboard LEDs.
>
> green:user1  default-trigger: heartbeat
> green:user2  default-trigger: mmc0/disk-activity(onboard-storage)
> green:user3  default-trigger: mmc1 (SD-card)
> green:user4  default-trigger: none, panic-indicator
> yellow:wlan  default-trigger: phy0tx
> blue:bt      default-trigger: hci0-power
>
> So lets adopt the same for APQ8016 SBC (Dragonboard410c), which is
> one of the 96Boards CE platform.

You are missing a signed-off here :-)

Acked-by: Amit Kucheria <amit.kucheria@...aro.org>

> ---
>  arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> index 46feedf7c989..35f95154316b 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> @@ -300,28 +300,28 @@
>                         compatible = "gpio-leds";
>
>                         led@1 {
> -                               label = "apq8016-sbc:green:user1";
> +                               label = "green:user1";
>                                 gpios = <&msmgpio 21 GPIO_ACTIVE_HIGH>;
>                                 linux,default-trigger = "heartbeat";
>                                 default-state = "off";
>                         };
>
>                         led@2 {
> -                               label = "apq8016-sbc:green:user2";
> +                               label = "green:user2";
>                                 gpios = <&msmgpio 120 GPIO_ACTIVE_HIGH>;
>                                 linux,default-trigger = "mmc0";
>                                 default-state = "off";
>                         };
>
>                         led@3 {
> -                               label = "apq8016-sbc:green:user3";
> +                               label = "green:user3";
>                                 gpios = <&pm8916_gpios 1 GPIO_ACTIVE_HIGH>;
>                                 linux,default-trigger = "mmc1";
>                                 default-state = "off";
>                         };
>
>                         led@4 {
> -                               label = "apq8016-sbc:green:user4";
> +                               label = "green:user4";
>                                 gpios = <&pm8916_gpios 2 GPIO_ACTIVE_HIGH>;
>                                 linux,default-trigger = "none";
>                                 panic-indicator;
> @@ -329,14 +329,14 @@
>                         };
>
>                         led@5 {
> -                               label = "apq8016-sbc:yellow:wlan";
> +                               label = "yellow:wlan";
>                                 gpios = <&pm8916_mpps 2 GPIO_ACTIVE_HIGH>;
>                                 linux,default-trigger = "phy0tx";
>                                 default-state = "off";
>                         };
>
>                         led@6 {
> -                               label = "apq8016-sbc:blue:bt";
> +                               label = "blue:bt";
>                                 gpios = <&pm8916_mpps 3 GPIO_ACTIVE_HIGH>;
>                                 linux,default-trigger = "bluetooth-power";
>                                 default-state = "off";
> --
> 2.17.1
>