linux-kernel - Re: [PATCH] perf/stat: Handle different PMU names with common prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4cba8c1c-e1ec-1972-5d12-97804cf6aa14@gydle.com>
Date:   Mon, 29 Oct 2018 08:50:59 -0400
From:   Sebastien Boisvert <sboisvert@...le.com>
To:     Thomas-Mich Richter <tmricht@...ux.ibm.com>,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        acme@...nel.org
Cc:     brueckner@...ux.vnet.ibm.com, schwidefsky@...ibm.com,
        heiko.carstens@...ibm.com, kan.liang@...ux.intel.com,
        stable@...r.kernel.org
Subject: Re: [PATCH] perf/stat: Handle different PMU names with common prefix



On 2018-10-29 8:18 a.m., Thomas-Mich Richter wrote:
> Yes, mistake on my side...
> but it is the same type of error , regardless if 6 or 7 characters are 
> compared:
> 
>       strncmp("cpmu_cf", "cpum_cf_diag", 7) 
> 
> returns 0 when it should not. The device names of both PMUs are different.
> 

OK, that works then.

You want to do a full-length comparison of PMU names, instead of comparing prefixes.

Reviewed-by: Sebastien Boisvert <sboisvert@...le.com>