linux-kernel - Re: [PATCH 2/4] kvm, vmx: move register clearing out of assembly path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1540820839.10039.9.camel@amazon.de>
Date:   Mon, 29 Oct 2018 13:47:19 +0000
From:   "Stecklina, Julian" <jsteckli@...zon.de>
To:     "jmattson@...gle.com" <jmattson@...gle.com>,
        "sean.j.christopherson@...el.com" <sean.j.christopherson@...el.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "js@...en8.de" <js@...en8.de>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>
Subject: Re: [PATCH 2/4] kvm, vmx: move register clearing out of assembly path

On Fri, 2018-10-26 at 09:30 -0700, Jim Mattson wrote:
> On Fri, Oct 26, 2018 at 8:46 AM, Sean Christopherson
> <sean.j.christopherson@...el.com> wrote:
> 
> > And FWIW, I find the original code to be more readable since all
> > GRPs
> > are zeroed with the same method.
> I concur. I really do prefer the explicit xors to the input
> arguments.

ACK. Will re-post with xor for everything.

Julian
Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B