linux-kernel - [PATCH 3/7] ext4 resize: missing brelse() in case success in add_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8c84f46-7ffe-7fd3-0e70-775c3c59320e@virtuozzo.com>
Date:   Mon, 29 Oct 2018 18:25:16 +0300
From:   Vasily Averin <vvs@...tuozzo.com>
To:     linux-ext4@...r.kernel.org, Theodore Ts'o <tytso@....edu>
Cc:     Andreas Dilger <adilger.kernel@...ger.ca>,
        linux-kernel@...r.kernel.org
Subject: [PATCH 3/7] ext4 resize: missing brelse() in case success in
 add_new_gdb()

Fixes ac27a0ec112a ("ext4: initial copy of files from ext3")
#? cc: stable <stable@...r.kernel.org>     # 2.6.19 or evel earlier in ext3

Signed-off-by: Vasily Averin <vvs@...nvz.org>
---
 fs/ext4/resize.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index 0a4dc6217e78..ff17480e8613 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -874,6 +874,7 @@ static int add_new_gdb(handle_t *handle, struct inode *inode,
 		goto exit_inode;
 	}
 	brelse(dind);
+	brelse(iloc.bh);
 
 	o_group_desc = EXT4_SB(sb)->s_group_desc;
 	memcpy(n_group_desc, o_group_desc,
-- 
2.17.1