lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Oct 2018 11:35:45 -0600 From: Jens Axboe <axboe@...nel.dk> To: Bart Van Assche <bvanassche@....org>, linux-block@...r.kernel.org, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 05/14] blk-mq: allow software queue to map to multiple hardware queues On 10/29/18 11:34 AM, Bart Van Assche wrote: > On Mon, 2018-10-29 at 10:37 -0600, Jens Axboe wrote: >> The mapping used to be dependent on just the CPU location, but >> now it's a tuple of { type, cpu} instead. This is a prep patch >> for allowing a single software queue to map to multiple hardware >> queues. No functional changes in this patch. > > A nitpick: mathematicians usually use the { } notation for sets and () for > tuples. See also https://en.wikipedia.org/wiki/Tuple. Alright :-) >> + /* wrap */ >> + BUG_ON(!hctx->nr_ctx); > > Another nitpick: how about changing the "wrap" comment into "detect integer > overflow" or so to make the purpose of the BUG_ON() statement more clear? Sure, I'll improve that one too. -- Jens Axboe
Powered by blists - more mailing lists