linux-kernel - Re: [PATCH v2] [PATCH] KEYS: trusted: fix -Wvarags warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOdn+V8iFJ_V1vr3GBm-NwxzaDbcmK+nW1q3uVky7bRsB3w@mail.gmail.com>
Date:   Mon, 29 Oct 2018 10:54:29 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     jarkko.sakkinen@...ux.intel.com
Cc:     dhowells@...hat.com,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        Nathan Chancellor <natechancellor@...il.com>,
        David.Laight@...lab.com, denkenz@...il.com,
        zohar@...ux.vnet.ibm.com, jmorris@...ei.org, serge@...lyn.com,
        keyrings@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org
Subject: Re: [PATCH v2] [PATCH] KEYS: trusted: fix -Wvarags warning

On Wed, Oct 24, 2018 at 1:37 AM Jarkko Sakkinen
<jarkko.sakkinen@...ux.intel.com> wrote:
>
> On Mon, 22 Oct 2018, ndesaulniers@...gle.com wrote:
> > Fixes the warning reported by Clang:
> > security/keys/trusted.c:146:17: warning: passing an object that
> > undergoes default
> >      argument promotion to 'va_start' has undefined behavior [-Wvarargs]
> >        va_start(argp, h3);
> >                       ^
> > security/keys/trusted.c:126:37: note: parameter of type 'unsigned
> > char' is declared here
> > unsigned char *h2, unsigned char h3, ...)
> >                               ^
> > Specifically, it seems that both the C90 (4.8.1.1) and C11 (7.16.1.4)
> > standards explicitly call this out as undefined behavior:
> >
> > The parameter parmN is the identifier of the rightmost parameter in
> > the variable parameter list in the function definition (the one just
> > before the ...). If the parameter parmN is declared with ... or with a
> > type that is not compatible with the type that results after
> > application of the default argument promotions, the behavior is
> > undefined.
> >
> > Link: https://github.com/ClangBuiltLinux/linux/issues/41
> > Link: https://www.eskimo.com/~scs/cclass/int/sx11c.html
> > Suggested-by: David Laight <David.Laight@...lab.com>
> > Suggested-by: Denis Kenzior <denkenz@...il.com>
> > Suggested-by: James Bottomley <jejb@...ux.vnet.ibm.com>
> > Suggested-by: Nathan Chancellor <natechancellor@...il.com>
> > Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
>
> /Jarkko

Bumping the maintainers if this isn't already picked up?

-- 
Thanks,
~Nick Desaulniers