linux-kernel - Re: [PATCH v2] codafs: Fix build using bare-metal toolchain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKaJLVvpNZW2a+3xc7PE0+iU1nm39A7PEjCu8F9ijrT+wEXOag@mail.gmail.com>
Date:   Mon, 29 Oct 2018 22:05:49 +0200
From:   Sam Protsenko <semen.protsenko@...aro.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        codalist@...a.cs.cmu.edu, coda@...cmu.edu,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Praneeth Bajjuri <praneeth@...com>
Subject: Re: [PATCH v2] codafs: Fix build using bare-metal toolchain

Hi Greg,

On Mon, Oct 29, 2018 at 10:03 PM, Sam Protsenko
<semen.protsenko@...aro.org> wrote:
> The kernel is self-contained project and can be built with bare-metal
> toolchain. But bare-metal toolchain doesn't define __linux__. Because of
> this u_quad_t type is not defined when using bare-metal toolchain and
> codafs build fails. This patch fixes it by defining u_quad_t type
> unconditionally.
>
> Signed-off-by: Sam Protsenko <semen.protsenko@...aro.org>
> ---

Can you please pull this one, if this applicable? I sent it a while
ago, but I guess it got lost in mailing list. It might be also
applicable to stable branch (as it fixes allmodconfig build for ARM
with bare-metal toolchain).

Thanks!

>  include/linux/coda.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/coda.h b/include/linux/coda.h
> index d30209b9cef8..0ca0c83fdb1c 100644
> --- a/include/linux/coda.h
> +++ b/include/linux/coda.h
> @@ -58,8 +58,7 @@ Mellon the rights to redistribute these changes without encumbrance.
>  #ifndef _CODA_HEADER_
>  #define _CODA_HEADER_
>
> -#if defined(__linux__)
>  typedef unsigned long long u_quad_t;
> -#endif
> +
>  #include <uapi/linux/coda.h>
>  #endif
> --
> 2.19.1
>