linux-kernel - Re: memcg oops: memcg_kmem_charge_memcg()->try_charge()->page_counter_try

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181029214913.GB13325@tower.DHCP.thefacebook.com>
Date:   Mon, 29 Oct 2018 21:49:16 +0000
From:   Roman Gushchin <guro@...com>
To:     Mike Galbraith <efault@....de>
CC:     Michal Hocko <mhocko@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-mm <linux-mm@...ck.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Vladimir Davydov <vdavydov.dev@...il.com>
Subject: Re: memcg oops:
 memcg_kmem_charge_memcg()->try_charge()->page_counter_try_charge()->BOOM

On Mon, Oct 29, 2018 at 09:46:54PM +0100, Mike Galbraith wrote:
> On Mon, 2018-10-29 at 18:54 +0000, Roman Gushchin wrote:
> > 
> > Hi Mike!
> > 
> > Thank you for the report!
> > 
> > Do you see it reliable every time you boot up the machine?
> 
> Yeah.
> 
> > How do you run kvm?
> 
> My VMs are full SW/data clones of my i7-4790/openSUSE <release> box.
> 
> >  Is there something special about your cgroup setup?
> 
> No, I generally have no use for cgroups.
> 
> > I've made several attempts to reproduce the issue, but haven't got anything
> > so far. I've used your config, and played with different cgroups setups.
> 
> Ah, I have cgroup_disable=memory on the command line, which turns out
> to be why your box doesn't explode, while mine does.

Yeah, here it is. I'll send the fix in few minutes. Please,
test it on your setup. Your tested-by will be appreciated.

Thanks!