linux-kernel - Re: [PATCH 4/4] base/drivers/topology: Default dmpis-mhz if they are not set in DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181030084502.r4ksevjn6ilfpyb4@vireshk-i7>
Date:   Tue, 30 Oct 2018 14:15:02 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     rjw@...ysocki.net, vincent.guittot@...aro.org,
        linux-kernel@...r.kernel.org,
        Chris Redpath <chris.redpath@...aro.org>,
        Quentin Perret <quentin.perret@...aro.org>,
        Amit Kucheria <amit.kucheria@...aro.org>,
        Nicolas Dechesne <nicolas.dechesne@...aro.org>,
        Niklas Cassel <niklas.cassel@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH 4/4] base/drivers/topology: Default dmpis-mhz if they are
 not set in DT

On 30-10-18, 09:39, Daniel Lezcano wrote:
> SCHED_CAPACITY_SCALE is the default value in this file.
> 
> eg.
> 
> DEFINE_PER_CPU(unsigned long, cpu_scale) = SCHED_CAPACITY_SCALE
> ...
> pr_err("cpu_capacity: partial information: fallback to 1024 for all
> CPUs\n");
> ...
> 
> So I prefer to use the SCHED_CAPACITY_SCALE for consistency.

> Yes, it is the default behavior as stated in the documentation:
> 
> "capacity-dmips-mhz property is all-or-nothing: if it is specified for a
> cpu node, it has to be specified for every other cpu nodes, or the
> system will fall back to the default capacity value for every CPU."
> 
> and also in the error message:
> 
> pr_err("cpu_capacity: partial information: fallback to 1024 for all
> CPUs\n");

Okay.

-- 
viresh