linux-kernel - Re: [PATCH 10/10] tools gpio: Override CFLAGS assignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181030093418.GC18538@krava>
Date:   Tue, 30 Oct 2018 10:34:18 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Jiri Olsa <jolsa@...nel.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Hartmut Knaack <knaack.h@....de>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Len Brown <len.brown@...el.com>,
        Markus Mayer <mmayer@...adcom.com>,
        Shuah Khan <shuah@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Thomas Renninger <trenn@...e.com>,
        Tzvetomir Stoyanov <tz.stoyanov@...il.com>,
        Zhang Rui <rui.zhang@...el.com>,
        "Herton R. Krzesinski" <herton@...hat.com>
Subject: Re: [PATCH 10/10] tools gpio: Override CFLAGS assignments

ping

thanks,
jirka

On Mon, Oct 22, 2018 at 04:50:07PM +0200, Jiri Olsa wrote:
> On Tue, Oct 16, 2018 at 05:06:05PM +0200, Jiri Olsa wrote:
> > hi,
> > while hardening some of the tools rpm, we noticed we
> > can't pass build flags to some of them. 
> > 
> > Sending separate tools fixes for what we found. It's
> > mostly override for CFLAGS and adding LDFLAGS to the
> > build commands.
> > 
> > thanks,
> > jirka
> > 
> > 
> > Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> > Cc: Hartmut Knaack <knaack.h@....de>
> > Cc: Jonathan Cameron <jic23@...nel.org>
> > Cc: Lars-Peter Clausen <lars@...afoo.de>
> > Cc: Len Brown <len.brown@...el.com>
> > Cc: Markus Mayer <mmayer@...adcom.com>
> > Cc: Shuah Khan <shuah@...nel.org>
> > Cc: Signed-off-by: Len Brown <len.brown@...el.com>
> > Cc: Steven Rostedt <rostedt@...dmis.org>
> > Cc: Thomas Renninger <trenn@...e.com>
> > Cc: Tzvetomir Stoyanov (VMware) <tz.stoyanov@...il.com>
> > Cc: Zhang Rui <rui.zhang@...el.com>
> > ---
> > Jiri Olsa (10):
> >       tools lib traceevent: Use LDFLAGS in the build commands
> >       tools perf: Pass build flags to traceevent build
> >       tools cpupower debug: Allow to use outside build flags
> >       tools cpupower: Override CFLAGS assignments
> >       tools power x86_energy_perf_policy: Override CFLAGS assignments and add LDFLAGS to build command
> >       tools thermal tmon: Override CFLAGS assignments
> >       tools thermal tmon: Use -O3 instead of -O1 if available
> >       tools power turbostat: Override CFLAGS assignments and add LDFLAGS to build command
> >       tools iio: Override CFLAGS assignments
> >       tools gpio: Override CFLAGS assignments
> 
> the last one did not get post for some reason,
> attaching it now
> 
> jirka
> 
> 
> ---
> So user could specify outside CFLAGS values.
> 
> Cc: Jonathan Cameron <jic23@...nel.org>
> Cc: Hartmut Knaack <knaack.h@....de>
> Cc: Lars-Peter Clausen <lars@...afoo.de>
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> ---
>  tools/gpio/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/gpio/Makefile b/tools/gpio/Makefile
> index 240eda014b37..6ecdd1067826 100644
> --- a/tools/gpio/Makefile
> +++ b/tools/gpio/Makefile
> @@ -12,7 +12,7 @@ endif
>  # (this improves performance and avoids hard-to-debug behaviour);
>  MAKEFLAGS += -r
>  
> -CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include
> +override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include
>  
>  ALL_TARGETS := lsgpio gpio-hammer gpio-event-mon
>  ALL_PROGRAMS := $(patsubst %,$(OUTPUT)%,$(ALL_TARGETS))
> -- 
> 2.17.2
>