linux-kernel - Re: [PATCH RFC v1 3/8] timer: Export next wakeup time of a CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFrV-YJ4k_4Vnm-eFx8YAUF9b82U7PLPLFkz2fzcqYWybw@mail.gmail.com>
Date:   Tue, 30 Oct 2018 11:29:29 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     "Raju P.L.S.S.S.N" <rplsssn@...eaurora.org>,
        Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Kevin Hilman <khilman@...nel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        linux-soc@...r.kernel.org, Rajendra Nayak <rnayak@...eaurora.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        DTML <devicetree@...r.kernel.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Evan Green <evgreen@...omium.org>,
        Doug Anderson <dianders@...omium.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Lina Iyer <ilina@...eaurora.org>,
        Lina Iyer <lina.iyer@...aro.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Frederic Weisbecker <fweisbec@...il.com>,
        Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH RFC v1 3/8] timer: Export next wakeup time of a CPU

On 29 October 2018 at 23:36, Thomas Gleixner <tglx@...utronix.de> wrote:
> Raju,
>
> On Thu, 11 Oct 2018, Raju P.L.S.S.S.N wrote:
>>
>> +/**
>> + * tick_nohz_get_next_wakeup - return the next wake up of the CPU
>
> Lacks documentation of @cpu. Please include kernel docs into your test
> builds.

Good point!

>
>> + */
>> +ktime_t tick_nohz_get_next_wakeup(int cpu)
>> +{
>> +     struct clock_event_device *dev = per_cpu(tick_cpu_device.evtdev, cpu);
>> +
>> +     return dev->next_event;
>> +}

Thanks for your review!

Kind regards
Uffe