Message-ID: <20181030123627.GS10650@smile.fi.intel.com>
Date:   Tue, 30 Oct 2018 14:36:27 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     Jason Wessel <jason.wessel@...driver.com>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        tglx@...utronix.de, mingo@...nel.org, gregkh@...uxfoundation.org,
        linux-arm-msm@...r.kernel.org,
        kgdb-bugreport@...ts.sourceforge.net, nm@...com,
        linux-mips@...ux-mips.org, dalias@...c.org,
        catalin.marinas@....com, vigneshr@...com,
        linux-aspeed@...ts.ozlabs.org, linux-sh@...r.kernel.org,
        peterz@...radead.org, will.deacon@....com, mhocko@...e.com,
        paulus@...ba.org, hpa@...or.com, sparclinux@...r.kernel.org,
        marex@...x.de, sfr@...b.auug.org.au, ysato@...rs.sourceforge.jp,
        linux-hexagon@...r.kernel.org, x86@...nel.org,
        linux@...linux.org.uk, pombredanne@...b.com, tony@...mide.com,
        mingo@...hat.com, joel@....id.au, linux-serial@...r.kernel.org,
        rolf.evers.fischer@...iv.com, jhogan@...nel.org,
        asierra@...-inc.com, linux-snps-arc@...ts.infradead.org,
        dan.carpenter@...cle.com, ying.huang@...el.com, riel@...riel.com,
        frederic@...nel.org, jslaby@...e.com, paul.burton@...s.com,
        rppt@...ux.vnet.ibm.com, bp@...en8.de, luto@...nel.org,
        linux-arm-kernel@...ts.infradead.org, christophe.leroy@....fr,
        andrew@...id.au, linux-kernel@...r.kernel.org, ralf@...ux-mips.org,
        rkuo@...eaurora.org, Jisheng.Zhang@...aptics.com,
        vgupta@...opsys.com, benh@...nel.crashing.org, jk@...abs.org,
        mpe@...erman.id.au, akpm@...ux-foundation.org,
        linuxppc-dev@...ts.ozlabs.org, davem@...emloft.net,
        kstewart@...uxfoundation.org
Subject: Re: [PATCH 0/7] serial: Finish kgdb on qcom_geni; fix many lockdep
 splats w/ kgdb

On Mon, Oct 29, 2018 at 11:07:00AM -0700, Douglas Anderson wrote:
> I started out this series trying to make sysrq work over the serial
> console on qcom_geni_serial, then fell into a rat's nest.
> 
> To solve the deadlock I faced when enabling sysrq I tried to borrow
> code from '8250_port.c' which avoided grabbing the port lock in
> console_write().  ...but since these days I try to run with lockdep on
> all the time, I found it caused an annoying lockdep splat (which I
> also reproduced on my rk3399 board).  ...so I instead changed my
> qcom_geni_serial solution to borrow code from 'msm_serial.c'
> 
> I wasn't super happy with the solution in 'msm_serial.c' though.  I
> don't like releasing the spinlock there.  Not only is it ugly but it
> means we are unlocking / re-locking _all the time_ even though sysrq
> characters are rare.  ...so I came up with what I think is a better
> solution and then implemented it for qcom_geni_serial.
> 
> Since I had a good way to test 8250-based UARTs, I also fixed that
> driver to use my new method.  When doing so, I ran into a missing
> msm_serial.c at all, so I didn't switch that (or all other serial
> drivers for that matter) to the new method.
> 
> After fixing all the above issues, I found the next lockdep splat in
> kgdb and I think I've worked around it in a good-enough way, but I'm
> much less confident about this.  Hopefully folks can take a look at
> it.
> 
> In general, patches earlier in this series should be "less
> controversial" and hopefully can land even if people don't like
> patches later in the series.  ;-)
> 
> Looking back, this is pretty much two series squashed that could be
> treated indepdently.  The first is a serial series and the second is a
> kgdb series.
> 
> For all serial patches I'd expect them to go through the tty tree once
> they've been reviewed.
> 
> If folks are OK w/ the 'smp' patch it probably should go in some core
> kernel tree.  The kgdb patch won't work without it, though, so to land
> that we'd need coordination between the folks landing that and the
> folks landing the 'smp' patch.

I have got only 0/7 and 5/7, everything okay with your mail client and other tools?

> 
> 
> Douglas Anderson (7):
>   serial: qcom_geni_serial: Finish supporting sysrq
>   serial: core: Allow processing sysrq at port unlock time
>   serial: qcom_geni_serial: Process sysrq at port unlock time
>   serial: core: Include console.h from serial_core.h
>   serial: 8250: Process sysrq at port unlock time
>   smp: Don't yell about IRQs disabled in kgdb_roundup_cpus()
>   kgdb: Remove irq flags and local_irq_enable/disable from roundup
> 
>  arch/arc/kernel/kgdb.c                      |  4 +--
>  arch/arm/kernel/kgdb.c                      |  4 +--
>  arch/arm64/kernel/kgdb.c                    |  4 +--
>  arch/hexagon/kernel/kgdb.c                  | 11 ++----
>  arch/mips/kernel/kgdb.c                     |  4 +--
>  arch/powerpc/kernel/kgdb.c                  |  2 +-
>  arch/sh/kernel/kgdb.c                       |  4 +--
>  arch/sparc/kernel/smp_64.c                  |  2 +-
>  arch/x86/kernel/kgdb.c                      |  9 ++---
>  drivers/tty/serial/8250/8250_aspeed_vuart.c |  6 +++-
>  drivers/tty/serial/8250/8250_fsl.c          |  6 +++-
>  drivers/tty/serial/8250/8250_omap.c         |  6 +++-
>  drivers/tty/serial/8250/8250_port.c         |  8 ++---
>  drivers/tty/serial/qcom_geni_serial.c       | 10 ++++--
>  include/linux/kgdb.h                        |  9 ++---
>  include/linux/serial_core.h                 | 38 ++++++++++++++++++++-
>  kernel/debug/debug_core.c                   |  2 +-
>  kernel/smp.c                                |  4 ++-
>  18 files changed, 80 insertions(+), 53 deletions(-)
> 
> -- 
> 2.19.1.568.g152ad8e336-goog
> 

-- 
With Best Regards,
Andy Shevchenko

Powered by blists - more mailing lists