linux-kernel - RE: [PATCH] tlclk: lean an indentation issue, remove extraneous tabs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 Oct 2018 15:41:06 +0000
From:   "Gross, Mark" <mark.gross@...el.com>
To:     Colin King <colin.king@...onical.com>,
        Arnd Bergmann <arnd@...db.de>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] tlclk: lean an indentation issue, remove extraneous tabs

Looks cool to me.

Reviewed-by <mark.gross@...el.com>

--mark

> -----Original Message-----
> From: Colin King [mailto:colin.king@...onical.com]
> Sent: Tuesday, October 30, 2018 4:57 AM
> To: Gross, Mark <mark.gross@...el.com>; Arnd Bergmann <arnd@...db.de>;
> Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] tlclk: lean an indentation issue, remove extraneous tabs
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> Trivial fix to clean up an indentation issue, remove tabs
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/char/tlclk.c | 84 ++++++++++++++++++++++----------------------
>  1 file changed, 42 insertions(+), 42 deletions(-)
> 
> diff --git a/drivers/char/tlclk.c b/drivers/char/tlclk.c index
> 8eeb4190207d..a0f2c0506176 100644
> --- a/drivers/char/tlclk.c
> +++ b/drivers/char/tlclk.c
> @@ -506,27 +506,27 @@ static ssize_t
> store_select_amcb2_transmit_clock(struct device *d,
> 
>  	val = (unsigned char)tmp;
>  	spin_lock_irqsave(&event_lock, flags);
> -		if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> -			SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x28);
> -			SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> -		} else if (val >= CLK_8_592MHz) {
> -			SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x38);
> -			switch (val) {
> -			case CLK_8_592MHz:
> -				SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> -				break;
> -			case CLK_11_184MHz:
> -				SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> -				break;
> -			case CLK_34_368MHz:
> -				SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> -				break;
> -			case CLK_44_736MHz:
> -				SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
> -				break;
> -			}
> -		} else
> -			SET_PORT_BITS(TLCLK_REG3, 0xc7, val << 3);
> +	if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> +		SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x28);
> +		SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> +	} else if (val >= CLK_8_592MHz) {
> +		SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x38);
> +		switch (val) {
> +		case CLK_8_592MHz:
> +			SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> +			break;
> +		case CLK_11_184MHz:
> +			SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> +			break;
> +		case CLK_34_368MHz:
> +			SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> +			break;
> +		case CLK_44_736MHz:
> +			SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
> +			break;
> +		}
> +	} else
> +		SET_PORT_BITS(TLCLK_REG3, 0xc7, val << 3);
> 
>  	spin_unlock_irqrestore(&event_lock, flags);
> 
> @@ -548,27 +548,27 @@ static ssize_t
> store_select_amcb1_transmit_clock(struct device *d,
> 
>  	val = (unsigned char)tmp;
>  	spin_lock_irqsave(&event_lock, flags);
> -		if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> -			SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x5);
> -			SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> -		} else if (val >= CLK_8_592MHz) {
> -			SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x7);
> -			switch (val) {
> -			case CLK_8_592MHz:
> -				SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> -				break;
> -			case CLK_11_184MHz:
> -				SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> -				break;
> -			case CLK_34_368MHz:
> -				SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> -				break;
> -			case CLK_44_736MHz:
> -				SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
> -				break;
> -			}
> -		} else
> -			SET_PORT_BITS(TLCLK_REG3, 0xf8, val);
> +	if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> +		SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x5);
> +		SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> +	} else if (val >= CLK_8_592MHz) {
> +		SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x7);
> +		switch (val) {
> +		case CLK_8_592MHz:
> +			SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> +			break;
> +		case CLK_11_184MHz:
> +			SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> +			break;
> +		case CLK_34_368MHz:
> +			SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> +			break;
> +		case CLK_44_736MHz:
> +			SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
> +			break;
> +		}
> +	} else
> +		SET_PORT_BITS(TLCLK_REG3, 0xf8, val);
>  	spin_unlock_irqrestore(&event_lock, flags);
> 
>  	return strnlen(buf, count);
> --
> 2.19.1