linux-kernel - Re: [PATCH] kbuild: remove unused cc-fullversion variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNASEogAqYTZHdtPWk4xZPXKkJPuWX9BF3o_Cy5s0jCB2cg@mail.gmail.com>
Date:   Wed, 31 Oct 2018 01:00:55 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>
Cc:     "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jonathan Corbet <corbet@....net>,
        Michal Marek <michal.lkml@...kovi.net>
Subject: Re: [PATCH] kbuild: remove unused cc-fullversion variable

On Tue, Oct 30, 2018 at 1:05 AM Masahiro Yamada
<yamada.masahiro@...ionext.com> wrote:
>
> The last user of cc-fullversion was removed by commit f2910f0e6835
> ("powerpc: remove old GCC version checks").
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---

Applied to linux-kbuild.




>  Documentation/kbuild/makefiles.txt | 15 ---------------
>  scripts/Kbuild.include             |  4 ----
>  2 files changed, 19 deletions(-)
>
> diff --git a/Documentation/kbuild/makefiles.txt b/Documentation/kbuild/makefiles.txt
> index 7b6a2b2..8da26c6 100644
> --- a/Documentation/kbuild/makefiles.txt
> +++ b/Documentation/kbuild/makefiles.txt
> @@ -537,21 +537,6 @@ more details, with real examples.
>         The third parameter may be a text as in this example, but it may also
>         be an expanded variable or a macro.
>
> -    cc-fullversion
> -       cc-fullversion is useful when the exact version of gcc is needed.
> -       One typical use-case is when a specific GCC version is broken.
> -       cc-fullversion points out a more specific version than cc-version does.
> -
> -       Example:
> -               #arch/powerpc/Makefile
> -               $(Q)if test "$(cc-fullversion)" = "040200" ; then \
> -                       echo -n '*** GCC-4.2.0 cannot compile the 64-bit powerpc ' ; \
> -                       false ; \
> -               fi
> -
> -       In this example for a specific GCC version the build will error out
> -       explaining to the user why it stops.
> -
>      cc-cross-prefix
>         cc-cross-prefix is used to check if there exists a $(CC) in path with
>         one of the listed prefixes. The first prefix where there exist a
> diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
> index ca21a35..19a63db 100644
> --- a/scripts/Kbuild.include
> +++ b/scripts/Kbuild.include
> @@ -147,10 +147,6 @@ cc-name = $(shell $(CC) -v 2>&1 | grep -q "clang version" && echo clang || echo
>  # cc-version
>  cc-version = $(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh $(CC))
>
> -# cc-fullversion
> -cc-fullversion = $(shell $(CONFIG_SHELL) \
> -       $(srctree)/scripts/gcc-version.sh -p $(CC))
> -
>  # cc-ifversion
>  # Usage:  EXTRA_CFLAGS += $(call cc-ifversion, -lt, 0402, -O1)
>  cc-ifversion = $(shell [ $(cc-version) $(1) $(2) ] && echo $(3) || echo $(4))
> --
> 2.7.4
>


-- 
Best Regards
Masahiro Yamada