linux-kernel - Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a20aaf3-65ce-a7ae-8a0e-877313483969@oracle.com>
Date:   Tue, 30 Oct 2018 10:15:04 -0700
From:   Santosh Shilimkar <santosh.shilimkar@...cle.com>
To:     unlisted-recipients:; (no To-header on input)
Cc:     Marc Zyngier <marc.zyngier@....com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        "arm@...nel.org" <arm@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Olof Johansson <olof@...om.net>, stable@...r.kernel.org
Subject: Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

Hi Arnd, Olof,

On 10/30/2018 4:11 AM, Marc Zyngier wrote:
> The Keystone QMSS driver is pretty damaged, in the sense that it
> does things like this:
> 
> 	irq_set_affinity_hint(irq, to_cpumask(&cpu_map));
> 
> where cpu_map is a local variable. As we leave the function, this
> will point to nowhere-land, and things will end-up badly.
> 
> Instead, let's use a proper cpumask that gets allocated, giving
> the driver a chance to actually work with things like irqbalance
> as well as have a hypothetical 64bit future.
> 
> Signed-off-by: Marc Zyngier <marc.zyngier@....com>
> ---
Could you please add this patch to your fixes branch ?

FWIW,
Acked-by: Santosh Shilimkar <ssantosh@...nel.org>