linux-kernel - Re: [PATCH 2/2] net: xilinx_emaclite: recheck condition after timeout in mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181030.112528.308459967263600648.davem@davemloft.net>
Date:   Tue, 30 Oct 2018 11:25:28 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kurt@...utronix.de
Cc:     anirudh@...inx.com, John.Linn@...inx.com, michal.simek@...inx.com,
        radhey.shyam.pandey@...inx.com, andrew@...n.ch,
        yuehaibing@...wei.com, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] net: xilinx_emaclite: recheck condition after
 timeout in mdio_wait()

From: Kurt Kanzenbach <kurt@...utronix.de>
Date: Tue, 30 Oct 2018 10:31:39 +0100

> The function could report a false positive if it gets preempted between reading
> the XEL_MDIOCTRL_OFFSET register and checking for the timeout.  In such a case,
> the condition has to be rechecked to avoid false positives.
> 
> Therefore, check for expected condition even after the timeout occurred.
> 
> Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de>

Same objections as your previous patch.

This isn't fixing anything.