linux-kernel - Re: [PATCH] net: mvpp2: Fix affinity hint allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181030.114014.1116832622602679074.davem@davemloft.net>
Date:   Tue, 30 Oct 2018 11:40:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     marc.zyngier@....com
Cc:     antoine.tenart@...tlin.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, thomas.petazzoni@...tlin.com,
        maxime.chevallier@...tlin.com, miquel.raynal@...tlin.com,
        gregory.clement@...tlin.com, nadavh@...vell.com,
        stefanc@...vell.com, ymarkman@...vell.com, mw@...ihalf.com
Subject: Re: [PATCH] net: mvpp2: Fix affinity hint allocation

From: Marc Zyngier <marc.zyngier@....com>
Date: Tue, 30 Oct 2018 15:41:00 +0000

> The mvpp2 driver has the curious behaviour of passing a stack variable
> to irq_set_affinity_hint(), which results in the kernel exploding
> the first time anyone accesses this information. News flash: userspace
> does, and irqbalance will happily take the machine down. Great stuff.
> 
> An easy fix is to track the mask within the queue_vector structure,
> and to make sure it has the same lifetime as the interrupt itself.
> 
> Fixes: e531f76757eb ("net: mvpp2: handle cases where more CPUs are available than s/w threads")
> Signed-off-by: Marc Zyngier <marc.zyngier@....com>
> ---
> As requested in https://lore.kernel.org/lkml/20181030135354.GD3407@kwain/

Applied.