linux-kernel - Re: [PATCH] fs/proc: introduce /proc/stat2 file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 Oct 2018 11:57:56 -0700
From:   Davidlohr Bueso <dave@...olabs.net>
To:     Vito Caputo <vcaputo@...garu.com>
Cc:     Waiman Long <longman@...hat.com>, akpm@...ux-foundation.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Davidlohr Bueso <dbueso@...e.de>
Subject: Re: [PATCH] fs/proc: introduce /proc/stat2 file

On Mon, 29 Oct 2018, Vito Caputo wrote:

>I'm definitely not in favor of just adding another stat file that is the
>same format as the existing one with the intrs zeroed out.  It's a dirty
>hack; fine for your local needs but too gross for upstream IMHO.

I suspect very few users of /proc/stat actually use the irq fields in the
first place. So the common case ends up doing unnecessary operations. The
stat2 approach is not perfect, but I think it's the best approach so far.
This sort of renaming is not uncommon when we cannot break userspace, and
its not like procfs is not already far contaminated already.

There are not enough users that care about this stuff, afaik. What you
suggest sounds like a lot of over-engineering.

Thanks,
Davidlohr