linux-kernel - Re: [PATCH] gpio: pl061: Move irq_chip definition inside struct pl061

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZxqtV2dk_CoDtwx9_iCy_hSt8E+HjDGu6WcBEBxc8ueA@mail.gmail.com>
Date:   Wed, 31 Oct 2018 11:33:24 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: pl061: Move irq_chip definition inside struct pl061

On Wed, Oct 24, 2018 at 7:29 PM Manivannan Sadhasivam
<manivannan.sadhasivam@...aro.org> wrote:

> Keeping the irq_chip definition static will make it shared with multiple
> giochips in the system. This practice is considered to be bad and now we
> will get the below warning from gpiolib core:
>
> "detected irqchip that is shared with multiple gpiochips: please fix the
> driver."
>
> Hence, move the irq_chip definition from static to `struct pl061` for
> using a unique irq_chip for each gpiochip.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>

Patch applied. Much better like this!

Yours,
Linus Walleij