linux-kernel - Re: [PATCH] dvb: Allow MAC addresses to be mapped to stable device names with udev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12108.1540984768@warthog.procyon.org.uk>
Date:   Wed, 31 Oct 2018 11:19:28 +0000
From:   David Howells <dhowells@...hat.com>
To:     Sean Young <sean@...s.org>
Cc:     dhowells@...hat.com,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        Michael Krufky <mkrufky@...uxtv.org>,
        Brad Love <brad@...tdimension.cc>, mchehab@...nel.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dvb: Allow MAC addresses to be mapped to stable device names with udev

Sean Young <sean@...s.org> wrote:

> > > Devices without a mac address shouldn't have a mac_dvb sysfs attribute,
> > > I think.
> > 
> > I'm not sure that's possible within the core infrastructure.  It's a class
> > attribute set when the class is created; I'm not sure it can be overridden on
> > a per-device basis.
> > 
> > Possibly the file could return "" or "none" in this case?
> 
> That's very ugly. Have a look at, for example, rc-core wakeup filters:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/media/rc/rc-main.c#n1844

By analogy, then, I think the thing to do is to put something like struct
rc_dev::sysfs_groups[] into struct dvb_device (or maybe struct dvb_adapter)
and then the dvb_mac attribute in there during dvb_register_device() based on
whether or not the MAC address is not all zeros at that point.

David