linux-kernel - Re: [Outreachy kernel] Re: [PATCH v2] staging: vboxvideo: Remove unnecessary parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 31 Oct 2018 12:05:51 -0300
From:   Shayenne Moura <shayenneluzmoura@...il.com>
To:     Sasha Levin <sashal@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Michael Thayer <michael.thayer@...cle.com>,
        devel@...verdev.osuosl.org, outreachy-kernel@...glegroups.com,
        linux-kernel@...r.kernel.org
Subject: Re: [Outreachy kernel] Re: [PATCH v2] staging: vboxvideo: Remove
 unnecessary parentheses

On 10/30, Sasha Levin wrote:
> On Tue, Oct 30, 2018 at 08:17:57PM -0300, Shayenne Moura wrote:
> > On 10/30, Greg Kroah-Hartman wrote:
> > > On Tue, Oct 23, 2018 at 02:43:04PM -0300, Shayenne da Luz Moura wrote:
> > > > Remove unneeded parentheses around the arguments of ||. This reduces
> > > > clutter and code behave in the same way.
> > > > Change suggested by checkpatch.pl.
> > > >
> > > > vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 <
> > > > crtc->x'
> > > >
> > > > Signed-off-by: Shayenne da Luz Moura <shayenneluzmoura@...il.com>
> > > > Reviewed-by: Hans de Goede <hdegoede@...hat.com>
> > > > ---
> > > > Changes in v2:
> > > >   - Make the commit message more clearer.
> > > 
> > > This patch does not apply to the latest kernel tree at all :(
> > > 
> > > Please fix up and resend.
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > 
> > Hi Greg!
> > 
> > Sorry, I do not know what branch are expected to be used.
> > I used the drm-misc-next to create this patch and I could not
> > find any merge problem.
> > 
> > Could you please tell me the details?
> 
> Hi Shayenne,
> 
> There's an easy trick for this: the kernel tree has a script that can
> help you find both the relevant maintainers, and their development tree
> for each file in the kernel.
> 
> Simply run:
> 
> 	./scripts/get_maintainer.pl --scm -f [filename]
> 
> For example, in this case, you'd run:
> 
> 	$ ./scripts/get_maintainer.pl --scm -f drivers/staging/vboxvideo/vbox_main.c
> 	Greg Kroah-Hartman <gregkh@...uxfoundation.org> (supporter:STAGING SUBSYSTEM,commit_signer:10/10=100%)
> 	Hans de Goede <hdegoede@...hat.com> (commit_signer:7/10=70%,authored:6/10=60%,added_lines:31/37=84%,removed_lines:153/159=96%)
> 	Fabio Rafael da Rosa <fdr@...42.net> (commit_signer:1/10=10%,authored:1/10=10%)
> 	Alexander Kapshuk <alexander.kapshuk@...il.com> (commit_signer:1/10=10%,authored:1/10=10%)
> 	Nicholas Mc Guire <der.herr@...r.at> (commit_signer:1/10=10%)
> 	Thomas Zimmermann <tzimmermann@...e.de> (authored:1/10=10%,added_lines:2/37=5%)
> 	Daniel Junho <djunho@...il.com> (authored:1/10=10%,added_lines:2/37=5%)
> 	devel@...verdev.osuosl.org (open list:STAGING SUBSYSTEM)
> 	linux-kernel@...r.kernel.org (open list)
> 	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> 
> The list of people and mailing lists are the ones that should be the
> recipients of your patch, and the last line is the git tree on which the
> patch should be based on.
> 
> --
> Thanks,
> Sasha

Thanks Sasha!

It is a very nice tip! 

Best regards,
Shayenne