linux-kernel - Re: [PATCH v3] staging: vboxvideo: Remove unnecessary parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <989f41f2-8b65-421a-7af3-69c35e7d2594@redhat.com>
Date:   Wed, 31 Oct 2018 16:32:08 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Shayenne da Luz Moura <shayenneluzmoura@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Thayer <michael.thayer@...cle.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        outreachy-kernel@...glegroups.com
Subject: Re: [PATCH v3] staging: vboxvideo: Remove unnecessary parentheses

Hi,

On 31-10-18 16:03, Shayenne da Luz Moura wrote:
> Remove unneeded parentheses around the arguments of ||. This reduces
> clutter and code behave in the same way.
> Change suggested by checkpatch.pl.
> 
> vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 <
> crtc->x'
> 
> Signed-off-by: Shayenne da Luz Moura <shayenneluzmoura@...il.com>

Thank you.

Still looks good to me:

Acked-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans



> ---
> Changes in v2:
>    - Make the commit message more clearer.
> 
> Changes in v3:
>    - Update to apply patch to the latest kernel tree
> 
>   drivers/staging/vboxvideo/vbox_main.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/vboxvideo/vbox_main.c b/drivers/staging/vboxvideo/vbox_main.c
> index 7466c1103ff6..ad0e0b62bd1e 100644
> --- a/drivers/staging/vboxvideo/vbox_main.c
> +++ b/drivers/staging/vboxvideo/vbox_main.c
> @@ -122,10 +122,10 @@ void vbox_framebuffer_dirty_rectangles(struct drm_framebuffer *fb,
>   			struct vbva_cmd_hdr cmd_hdr;
>   			unsigned int crtc_id = to_vbox_crtc(crtc)->crtc_id;
>   
> -			if ((rects[i].x1 > crtc_x + mode->hdisplay) ||
> -			    (rects[i].y1 > crtc_y + mode->vdisplay) ||
> -			    (rects[i].x2 < crtc_x) ||
> -			    (rects[i].y2 < crtc_y))
> +			if (rects[i].x1 > crtc_x + mode->hdisplay ||
> +			    rects[i].y1 > crtc_y + mode->vdisplay ||
> +			    rects[i].x2 < crtc_x ||
> +			    rects[i].y2 < crtc_y)
>   				continue;
>   
>   			cmd_hdr.x = (s16)rects[i].x1;
>