linux-kernel - Re: [PATCH] remove old GCC version implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNARyykVuHT1YQ_UWVMFRG-K3VQwEXtjGQxQE4Fgu4wQtDg@mail.gmail.com>
Date:   Thu, 1 Nov 2018 01:13:19 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     Mathieu Malaterre <malat@...ian.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] remove old GCC version implementation

On Wed, Oct 31, 2018 at 8:28 PM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> On Wed, Oct 31, 2018 at 12:18 PM Mathieu Malaterre <malat@...ian.org> wrote:
> >
> > GCC 4.6 is the minimum supported now.
> >
> > Signed-off-by: Mathieu Malaterre <malat@...ian.org>
> > ---
> >  scripts/mod/file2alias.c | 6 +-----
> >  1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
> > index 28a61665bb9c..4b59564d4706 100644
> > --- a/scripts/mod/file2alias.c
> > +++ b/scripts/mod/file2alias.c
> > @@ -83,11 +83,7 @@ extern struct devtable *__start___devtable[], *__stop___devtable[];
> >  #endif /* __MACH__ */
> >
> >  #if !defined(__used)
> > -# if __GNUC__ == 3 && __GNUC_MINOR__ < 3
> > -#  define __used                       __attribute__((__unused__))
> > -# else
> > -#  define __used                       __attribute__((__used__))
> > -# endif
> > +#define __used                 __attribute__((__used__))
> >  #endif
> >
>
> Acked-by: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
>
> By the way, is it possible that scripts/ and similar stuff uses
> directly include/linux/compiler_attributes.h (whenever it hits
> mainline, see https://github.com/ojeda/linux/blob/compiler-attributes/include/linux/compiler_attributes.h
> )? It is a header that does not depend on anything, so it could easily
> be shared; and would avoid having to maintain two sets of attributes.
> Let me know, I can take a look at it if you think it is a good idea.

No.
I want to share a header file between kernel and host-tools
only when we need to do so.


In this case, it is wrong to use the linker magic for the host tool
if you look at the so ugly #if defined(__MACH__) part.






> Cheers,
> Miguel



-- 
Best Regards
Masahiro Yamada