linux-kernel - Re: Git pull ack emails..

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wht_ohu8T1yA_cB1VG2=V25X0_2FEbBdq=PsFd50g9pRg@mail.gmail.com>
Date:   Wed, 31 Oct 2018 11:34:44 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     kirill@...temov.name, Linus Walleij <linus.walleij@...aro.org>,
        Boris Brezillon <boris.brezillon@...tlin.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Christoph Hellwig <hch@....de>,
        Guenter Roeck <linux@...ck-us.net>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Jens Axboe <axboe@...nel.dk>, Mark Brown <broonie@...nel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Git pull ack emails..

On Wed, Oct 31, 2018 at 7:28 AM Konstantin Ryabitsev
<konstantin@...uxfoundation.org> wrote:
>
> Regarding your case specifically, what's a good cutoff period for
> treating a pull request as effectively ignored/abandoned (i.e. no
> matching commit-id ever found in the repo). I'm guessing about a month,
> or do you want to go longer, in case something shifts to the following
> merge window?

Oh, I'd definitely not go longer - if anything, I think it could be shorter.

My *normal* reaction time is on the order of days. But yes, every
merge window there are a couple of pulls that I end up delaying to the
end of the merge window when I'm supposed to have more time to really
review them. Right now I have three such pull requests pending, for
example (and had planned to look at them today, but then new "normal"
pull requests happened, so I still haven't gotten around to them).

But even when those things get put in my queue, the queue shouldn't be
longer than the 2-week merge window, and if it is, I end up responding
separately (ie writing people "ok, I'm still mulling this over, but
it's not making rc1").

So I think a one-month queue is more than sufficient, and if there are
reasons to time things out earlier, a two-week one would be perfectly
fine too.

                  Linus