linux-kernel - Re: [PATCH 17/28] tools include uapi: Update asound.h copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181031192951.GE6669@redhat.com>
Date:   Wed, 31 Oct 2018 17:29:51 -0200
From:   Arnaldo Carvalho de Melo <acme@...hat.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Takashi Iwai <tiwai@...e.de>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Clark Williams <williams@...hat.com>,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Takashi Sakamoto <o-takashi@...amocchi.jp>
Subject: Re: [PATCH 17/28] tools include uapi: Update asound.h copy

Em Wed, Oct 31, 2018 at 10:27:02AM -0700, Joe Perches escreveu:
> On Wed, 2018-10-31 at 18:00 +0100, Takashi Iwai wrote:
> > On Wed, 31 Oct 2018 17:44:57 +0100,
> > Arnaldo Carvalho de Melo wrote:
> > > From: Arnaldo Carvalho de Melo <acme@...hat.com>
> > > 
> > > To silence this perf build warning:
> > > 
> > >   Warning: Kernel ABI header at 'tools/include/uapi/sound/asound.h' differs from latest version at 'include/uapi/sound/asound.h'
> > >   diff -u tools/include/uapi/sound/asound.h include/uapi/sound/asound.h
> > > 
> > > Due to this cset:
> > > 
> > >   a98401518def ("ALSA: timer: fix wrong comment to refer to 'SNDRV_TIMER_PSFLG_*'")
> > > 
> > > Cc: Jiri Olsa <jolsa@...nel.org>
> > > Cc: Namhyung Kim <namhyung@...nel.org>
> > > Cc: Takashi Sakamoto <o-takashi@...amocchi.jp>
> > > Cc: Takashi Iwai <tiwai@...e.de>
> > > Link: https://lkml.kernel.org/n/tip-76gsvs0w2g0x723ivqa2xua3@git.kernel.org
> > > Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> > 
> > Thanks for the correction.
> > 
> > That's bad to have duped files that have to be synced manually...
> > At least, some checkpatch addition would help to suggest always
> > correct both places?
> 
> How could that work in checkpatch?

No need for changes.
 
> Wouldn't a symlink be simpler?

That would be equivalent to using it directly, see my response to
Takashi for a few of the reasons this is done this way.

- Arnaldo