linux-kernel - Re: [PATCH] memory_hotplug: cond_resched in __remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181031214208.GA5564@dhcp22.suse.cz>
Date:   Wed, 31 Oct 2018 22:42:08 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Dan Williams <dan.j.williams@...il.com>,
        Johannes Thumshirn <jthumshirn@...e.de>, linux-mm@...ck.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] memory_hotplug: cond_resched in __remove_pages

On Wed 31-10-18 12:15:50, Andrew Morton wrote:
> On Wed, 31 Oct 2018 13:58:40 +0100 Michal Hocko <mhocko@...nel.org> wrote:
> 
> > From: Michal Hocko <mhocko@...e.com>
> > 
> > We have received a bug report that unbinding a large pmem (>1TB)
> > can result in a soft lockup:
> > 
> > ...
> >
> > It has been reported on an older (4.12) kernel but the current upstream
> > code doesn't cond_resched in the hot remove code at all and the given
> > range to remove might be really large. Fix the issue by calling cond_resched
> > once per memory section.
> > 
> 
> Worthy of a cc:stable, I suggest?

It is simple enough and we will surely have it in 4.12 based SLES
kernels. So I do not really mind cc: stable.

-- 
Michal Hocko
SUSE Labs