linux-kernel - Re: arm64 tools build failure wrt smp_load_{acquire,release} expansion on gcc version 5.4.0 20160609 (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181101091343.GA1565@brain-police>
Date:   Thu, 1 Nov 2018 09:13:43 +0000
From:   Will Deacon <will.deacon@....com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Daniel Borkmann <daniel@...earbox.net>,
        Peter Zijlstra <peterz@...radead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: arm64 tools build failure wrt smp_load_{acquire,release}
 expansion on gcc version 5.4.0 20160609 (Ubuntu/Linaro
 5.4.0-6ubuntu1~16.04.9)

[apologies if you get this twice -- my GPU hung (!) whilst sending my
 previous response]

On Wed, Oct 31, 2018 at 06:14:56PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Oct 31, 2018 at 07:08:29PM +0100, Daniel Borkmann escreveu:
> > On 10/31/2018 06:44 PM, Will Deacon wrote:
> > > Diff below...
>  
> > I just gave this a spin on 16.04 and it resolves the build issue, thanks
> > for the quick fix, Will!
>  
> > Tested-by: Daniel Borkmann <daniel@...earbox.net>
> 
> It buildz, ship it:
> 
> # time dm android-ndk:r12b-arm \
> 	  android-ndk:r15c-arm \
> 	  debian:experimental-x-arm64 \
> 	  ubuntu:14.04.4-x-linaro-arm64 \
> 	  ubuntu:16.04-x-arm \
> 	  ubuntu:16.04-x-arm64 \
> 	  ubuntu:18.04-x-arm \
> 	  ubuntu:18.04-x-arm64
>    1 android-ndk:r12b-arm          : Ok   arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
>    2 android-ndk:r15c-arm          : Ok   arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
>    3 debian:experimental-x-arm64   : Ok   aarch64-linux-gnu-gcc (Debian 8.2.0-7) 8.2.0
>    4 ubuntu:14.04.4-x-linaro-arm64 : Ok   aarch64-linux-gnu-gcc (Linaro GCC 5.5-2017.10) 5.5.0
>    5 ubuntu:16.04-x-arm            : Ok   arm-linux-gnueabihf-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
>    6 ubuntu:16.04-x-arm64          : Ok   aarch64-linux-gnu-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
>    7 ubuntu:18.04-x-arm            : Ok   arm-linux-gnueabihf-gcc (Ubuntu/Linaro 7.3.0-27ubuntu1~18.04) 7.3.0
>    8 ubuntu:18.04-x-arm64          : Ok   aarch64-linux-gnu-gcc (Ubuntu/Linaro 7.3.0-27ubuntu1~18.04) 7.3.0
> #
> 
> So I've added it to my tree as below, can I keep it like that?

Yup, thanks for turning it into a proper patch. Just to be explicit, here's
my s-o-b:

Signed-off-by: Will Deacon <will.deacon@....com>

Will