linux-kernel - Re: [PATCH 10/16] blk-mq: cleanup and improve list insertion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <579cc1b0-0147-d5b9-a507-85b56c2e0546@suse.de>
Date:   Thu, 1 Nov 2018 10:28:48 +0100
From:   Hannes Reinecke <hare@...e.de>
To:     Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
        linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/16] blk-mq: cleanup and improve list insertion

On 10/30/18 7:32 PM, Jens Axboe wrote:
> It's somewhat strange to have a list insertion function that
> relies on the fact that the caller has mapped things correctly.
> Pass in the hardware queue directly for insertion, which makes
> for a much cleaner interface and implementation.
> 
> Signed-off-by: Jens Axboe <axboe@...nel.dk>
> ---
>   block/blk-mq-sched.c |  8 +-------
>   block/blk-mq-sched.h |  2 +-
>   block/blk-mq.c       | 25 ++++++++++++++-----------
>   3 files changed, 16 insertions(+), 19 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes