linux-kernel - RE: [PATCH] x86/build: Build VSMP support only if selected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN6PR15MB2366D7688B41535AF0A331F9C3CE0@SN6PR15MB2366.namprd15.prod.outlook.com>
Date:   Thu, 1 Nov 2018 10:39:32 +0000
From:   "Shai Fultheim (Shai@...leMP.com)" <Shai@...leMP.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Randy Dunlap <rdunlap@...radead.org>
CC:     Andrew Morton <akpm@...ux-foundation.org>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "mhocko@...e.cz" <mhocko@...e.cz>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        "linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "mm-commits@...r.kernel.org" <mm-commits@...r.kernel.org>,
        Ravikiran Thirumalai <kiran@...lemp.com>,
        X86 ML <x86@...nel.org>,
        "'Eial Czerwacki (eial@...lemp.com)'" <eial@...lemp.com>,
        'Oren Twaig' <oren@...lemp.com>
Subject: RE: [PATCH] x86/build: Build VSMP support only if selected

On 01/11/18 11:37, Thomas Gleixner wrote:

> VSMP support is built even if CONFIG_X86_VSMP is not set. This leads to a build
> breakage when CONFIG_PCI is disabled as well.
> 
> Build VSMP code only when selected.

This patch disables detect_vsmp_box() on systems without CONFIG_X86_VSMP, due to
the recent 6da63eb241a05b0e676d68975e793c0521387141.  This is significant
regression that will affect significant number of deployments.

We will reply shortly with an updated patch that fix the dependency on pv_irq_ops,
and revert to CONFIG_PARAVIRT, with proper protection for CONFIG_PCI.