linux-kernel - Re: [PATCH v2 2/3] kvm, vmx: move register clearing out of assembly path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1541079629.1777.9.camel@amazon.de>
Date:   Thu, 1 Nov 2018 13:40:29 +0000
From:   "Stecklina, Julian" <jsteckli@...zon.de>
To:     "sean.j.christopherson@...el.com" <sean.j.christopherson@...el.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "js@...en8.de" <js@...en8.de>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>
Subject: Re: [PATCH v2 2/3] kvm, vmx: move register clearing out of assembly
 path

On Mon, 2018-10-29 at 10:26 -0700, Sean Christopherson wrote:
> I think it's a good idea to explicitly call out that clearing the
> GPRs
> is done to prevent speculative use.  Simply stating that we don't
> want
> to let guest register values survive doesn't explain *why*.
> 
> What about:
> 
>         /*
>          * Explicitly clear (in addition to marking them as
> clobbered) all GPRs
>          * that have not been loaded with host state to prevent
> speculatively
>          * using the guest's values.
>          */

Sounds good. I've also updated the commit message for the register
clearing commit. I'll repost the patches.

Julian



Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrer: Christian Schlaeger, Ralf Herbrich
Ust-ID: DE 289 237 879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B