linux-kernel - Re: [PATCH] tsc: make calibration refinement more robust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1811011630310.1642@nanos.tec.linutronix.de>
Date:   Thu, 1 Nov 2018 16:34:18 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Daniel Vacek <neelx@...hat.com>
cc:     x86@...nel.org, Ingo Molnar <mingo@...hat.com>,
        Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] tsc: make calibration refinement more robust

Daniel,

On Thu, 1 Nov 2018, Daniel Vacek wrote:

Please use 'x86/tsc:' as prefix. git log path/to/file usually gives you a
reasonable hint about prefixes.

> -#define MAX_RETRIES     5
> -#define SMI_TRESHOLD    50000
> +#define MAX_RETRIES	5
> +#define TSC_THRESHOLD	(tsc_khz >> 5)

This breaks pit_hpet_ptimer_calibrate_cpu() because at that point tsc_hkz is 0.

Thanks,

	tglx