linux-kernel - Re: [PATCH 06/16] blk-mq: add 'type' attribute to the sysfs hctx directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 1 Nov 2018 16:50:22 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Omar Sandoval <osandov@...ndov.com>
Cc:     linux-block@...r.kernel.org, linux-nvme@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/16] blk-mq: add 'type' attribute to the sysfs hctx
 directory

On 11/1/18 3:59 PM, Omar Sandoval wrote:
> On Tue, Oct 30, 2018 at 12:32:42PM -0600, Jens Axboe wrote:
>> It can be useful for a user to verify what type a given hardware
>> queue is, expose this information in sysfs.
>>
>> Reviewed-by: Hannes Reinecke <hare@...e.com>
>> Reviewed-by: Bart Van Assche <bvanassche@....org>
>> Signed-off-by: Jens Axboe <axboe@...nel.dk>
>> ---
>>  block/blk-mq-sysfs.c | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
> 
> Out of curiousity, why sysfs instead of debugfs?

I don't feel that strongly about it, but it is a property
like the mapped CPUs, for instance, so kind of makes sense to
put it there rather than in debugfs.

-- 
Jens Axboe