linux-kernel - Re: [PATCH] clk: fixed-factor: fix of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <154111644708.88331.6842371975986185473@swboyd.mtv.corp.google.com>
Date:   Thu, 01 Nov 2018 16:54:07 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Alan Tull <atull@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
Subject: Re: [PATCH] clk: fixed-factor: fix of_node_get-put imbalance

Quoting Ricardo Ribalda Delgado (2018-11-01 06:15:49)
> When the fixed factor clock is created by devicetree,
> of_clk_add_provider is called.  Add a call to
> of_clk_del_provider in the remove function to balance
> it out.
> 
> Reported-by: Alan Tull <atull@...nel.org>
> Fixes: 971451b3b15d ("clk: fixed-factor: Convert into a module platform driver")
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
> ---

Looks good. I'll queue this up for clk-fixes next week.